rero / rero-ils / 30899163511

91%

Build Type

push

github

Committed by rerowep

Commit Message

fix(entities): link MEF by identifier, not type

* replace.py: identifier alone now links contribution/subjects/
  genreForm entries to MEF; search falls back across every MEF family
  allowed for the field when the locally-declared type is wrong
* replace.py: contribution type mismatches are tracked in a new
  `type_mismatch` dict, no longer conflated with the `rero_only` retry
  cache, which was silently blocking later documents sharing the same
  identifier
* replace.py: document query now derives allowed entity types from
  `RERO_ILS_ENTITIES_TYPES_FIELDS`, so `bf:Work`-only subjects are no
  longer skipped from scanning
* sync.py: `sync_record` recursion is now capped to guard against a
  pathological MEF pid cycle; raises specific `RuntimeError`s instead
  of the bare `Exception` class
* utils.py: `get_mef_data_by_type` reports a clear "no result" error
  instead of a confusing IndexError-derived message
* proxy.py: `search()` no longer forwards cookies or arbitrary
  headers to the remote MEF server; deduplicated `_get_query_params`
  and removed a dead `_post_process_result_hit` override
* sync.py, replace.py: switched logging calls to lazy %-style
  formatting instead of f-strings
* cli.py: stopped reaching into a private method from outside the
  class
* Closes #4176.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

Coverage Stats

87 of 113 new or added lines in 6 files covered. (76.99%)

1 existing line in 1 file now uncovered.

24278 of 26607 relevant lines covered (91.25%)

0.91 hits per line