markitosgv / JWTRefreshTokenBundle / 30890657843

100%

push

github

perf: stop looking the refresh token up twice

A refresh went through the authenticator, which loads the token to authenticate
with it, and then through the listener, which loaded it again. Two queries for
one row, reported in 2018.

It was judged unfixable in 2021 because the legacy and the newer authentication
APIs differed in when the security token reached storage. The legacy one is gone
as of 2.0, and AuthenticatorManager sets the token before calling the success
handler, so the authenticated token is to hand by the time the listener runs.

The stored value is compared rather than the type trusted, so a token left in
storage by anything other than this request is never the one acted on. That
comparison cannot match when the stored value is a hash, which simply means the
query happens as it used to.

8 of 8 new or added lines in 1 file covered. (100.0%)

1257 of 1293 relevant lines covered (97.22%)

18.29 hits per line