lsm / HyperNeo / 30780698329

83%

Build Type

push

github

Committed by web-flow

Commit Message

[#2302] L3 primitives + re-express built_ins as named presets (epic #2299) (#2340)

* refactor(space): promote L3/L4 connector primitives from spike to production [#2302]

The L3 domain-agnostic layer (`predicate.ts`, `external-state-validator.ts`)
and the L4 coding-pack presets (`presets.ts`) are production, not a throwaway
spike. Drop the `HYPERNEO_WORKFLOW_CONNECTORS_SPIKE` gate + the now-unused
`registerSpikeConnectors`/`isConnectorsSpikeEnabled` (no external callers), and
re-frame the module/test headers accordingly.

No behavior change: the L2 layer is unchanged; these pieces were already
exercised by tests. They are wired into the engine by the next commit.

* feat(space): registry-drive built-in validator admission; add pr_merged preset [#2302]

The engine no longer special-cases any built-in validator id (epic #2299 ADR
#2 / the #2302 exit criterion). A new leaf registry is the single source of
truth for which ids are implemented:

  - `workflow-hook-validation.ts` admits a `built_in` id iff it is registered
    (replaces the hardcoded `Set(['pr_ready'])` literal; the error now lists
    the registered presets).
  - `hook-executor.ts` dispatches by registry lookup (replaces the local Map
    + the six `NOT_IMPLEMENTED` stubs, which were dead — validation already
    rejected those ids).

Named presets are registered in `built-in-validators/index.ts`, imported for
its side effect by validation so the registry is populated before any
validation runs:

  - `pr_ready`  — keeps the production impl (discovery + patch_params + exact
                  reason strings) so the one deployed github path is
                  byte-identical; its L3-over-L2 form (`createPrReadyValidatorV2`)
                  is the proven target for a later cutover.
  - `pr_merged` — net-new mark_complete merge gate, expressed directly as an
                  `external_state` preset over the github connector's `getPr` op.

`pr_merged` is added to `WorkflowHookValidatorId` an... (continued)

Coverage Stats

12362 of 17611 branches covered (70.19%)

Branch coverage included in aggregate %.

40 of 45 new or added lines in 7 files covered. (88.89%)

138 existing lines in 6 files now uncovered.

105720 of 124125 relevant lines covered (85.17%)

300.94 hits per line