lsm / HyperNeo / 30778330762

83%

push

github

feat(space): promote L2 connector abstraction + register github connector [#2301] (#2316)

* feat(space): promote L2 connector abstraction + register github connector [#2301]

Lands the L2 Connector abstraction as the engine's typed extension point
(epic #2299, P1), promoting the #2300 spike's throwaway contract to production
and replacing every hardcoded 'github' with a connector-registry lookup.

- Promote connectors/connector.ts: Connector/ConnectorOp/ConnectorOutcome +
  registry become production; add ConnectorAuth (envKeys + resolveExtraEnv) so
  sandboxed hook-env credential injection is connector-driven, and
  isConnectorsLayerEnabled() (default on, HYPERNEO_WORKFLOW_CONNECTORS=0 legacy
  fallback). isConnectorsSpikeEnabled() now gates only the L3/L4 experiment.
- Register the github connector (production.ts) and declare built-in connector
  deps there (pr_ready -> [github]); the engine reads getBuiltInConnectorDeps()
  instead of 'id === pr_ready'. github is one registered connector.
- Remove hardcoded 'github': workflow-hook-validation admits registered
  connectors; workflow-hook-engine resolves permitted lookups via the registry;
  hook-executor injects connector-declared env keys; WorkflowHookExternalLookup
  widens to string (a connector id); migration uses GITHUB_CONNECTOR_ID.
- Extract runtime/gh-lookup-helpers.ts (the deferred shared helper): env builder
  + resolveGithubConfigDir + runGhJson + rate-limit probe, shared by pr-ready
  and the github connector. Deletes the spike-local gh-client.ts.
- pr_ready's execution is byte-identical (same lookups, decision matrix,
  patch_params, rate-limit handling) -- the adapter is at the permission/auth
  layer; P2 (#2302) re-expresses execution as a preset. Behavior-preserving for
  the deployed coding workflows.

Flag-guarded per the epic (default on, opt-out fallback). L3/L4 pieces
(external-state-validator, predicate, presets) remain spike-gated for P2.

* fix(space): deny unpermitted conne... (continued)

12362 of 17611 branches covered (70.19%)

Branch coverage included in aggregate %.

116 of 192 new or added lines in 13 files covered. (60.42%)

105723 of 124136 relevant lines covered (85.17%)

300.64 hits per line