archetech / archon / 30776572069

94%

main: 94%

Pull #833

github

ci: run the gatekeeper TS/Rust parity harness, and fix what it found

Closes #771.

The issue reported that api-parity-flows.json declares a parity harness
that nothing runs, and proposed either wiring up a runner or deleting the
manifest. Neither applies: the runner already exists.
scripts/gatekeeper-parity.mjs reads both manifests and implements the
flow engine. The issue's grep covered *.ts, *.js, *.rs, *.yml and *.json
— the runner is a .mjs file, the one extension not in the list. My first
grep repeated the omission.

The real gap was automation. The script needed two live services and had
no npm script or CI step, so parity was maintained by porting discipline
with no regression guard.

This adds docker/compose/gatekeeper-parity.yml, which runs both
implementations side by side, and a `gatekeeper parity` job that replays
every fixture and flow on each PR. The two services get separate storage
— the flows create DIDs, so a shared store would turn the second
implementation's create into a duplicate — but deliberately share IPFS,
which is content-addressed, so a CID divergence is itself worth failing
on.

Running it for the first time found four defects:

1. POST /queue/:registry/clear returned `true` from TypeScript and `[]`
   from Rust. GatekeeperDb.clearQueue and GatekeeperClient.clearQueue are
   both typed Promise<boolean>, so a TS client against a Rust gatekeeper
   received an array where it expected a boolean — masked because `[]` is
   truthy, so `if (await clearQueue(...))` worked by accident. Rust was
   faithfully implementing the swagger annotation, which documented an
   array and was itself wrong; the annotation is corrected and the
   OpenAPI spec regenerated.

2. The same handler did `let _ = store.clear_queue(...)`, discarding the
   Result, so a storage failure was reported to the caller as success.

3. The legacy /api/v1/did/ surface classified resolution errors with a
   crude `did:` prefix check, so a malformed CID or a forei... (continued)

3606 of 4060 branches covered (88.82%)

Branch coverage included in aggregate %.

8229 of 8511 relevant lines covered (96.69%)

687.18 hits per line