archetech / archon / 30774067785

94%

push

github

test(keymaster): cover WalletSQLite defaults and connection guards (#832)

db/sqlite.ts reaches 100% on both branches (53.8% -> 100%) and lines
(93.1% -> 100%). Four of the six untaken branches were unexercised
default parameters on the constructor and create(); the other two were
the defensive `!this.db` guards, reachable only by stubbing connect() to
a no-op, since a successful connect always sets the handle.

Exercising the default constructor arguments surfaced a real asymmetry
between the two wallet backends:

    // WalletJson.saveWallet
    if (!fs.existsSync(this.dataFolder)) {
        fs.mkdirSync(this.dataFolder, { recursive: true });
    }

    // WalletSQLite.connect — no equivalent

WalletSQLite opens `${dataFolder}/${file}` directly, so an absent
directory fails with a raw SQLITE_CANTOPEN rather than being created or
reported clearly. The existing tests never hit it because they always
pass an already-created temp dir; only the default-argument path exposes
it.

Pinned by test asserting current behaviour rather than changed — whether
the two implementations of the same interface should agree is a design
call. Worth knowing that a fresh deployment relying on the sqlite wallet
needs `data/` to exist beforehand.

Repo branches 86.46% -> 86.68%.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

3606 of 4060 branches covered (88.82%)

Branch coverage included in aggregate %.

8229 of 8511 relevant lines covered (96.69%)

687.18 hits per line