lsm / HyperNeo / 30775840023

83%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(space): consolidate rate/usage-limited paused-status predicate (#2317)

* refactor(space): consolidate rate/usage-limited paused-status predicate

Introduce isRateOrUsageLimited() in shared/types/space-utils.ts as the single
source of truth for "is this task paused on a rate/usage cap?" and route every
duplicated `status === 'rate_limited' || status === 'usage_limited'` check
through it: processRunTick guard, concurrency-slot count, validateTaskAllowsSpawn,
isLimited / restoreTaskFromRateLimit / parentLimited, isWorkflowRecoveryTransition,
isActionRequired, isActiveTaskStatus, dependency-cancel, stopActiveWork,
auto-clear-restrictions, and shouldStopWorkflowForStatus.

Adding or removing a paused status is now a one-line edit every consumer picks
up in lockstep. Semantics unchanged; the kind-discriminating checks in
markTaskRateLimited (which need usage-vs-rate, not whether) stay inline.

* test(space): enforce ALL_SPACE_TASK_STATUSES exhaustiveness at compile time

Address review P2 on #2317: the test fixture was a hand-maintained
SpaceTaskStatus[], so a future status added to the union would be silently
omitted and the "exhaustive" filter assertion would pass without covering it.
Switch to `as const satisfies readonly SpaceTaskStatus[]` and add a
bidirectional exhaustiveness assertion that turns a missing union member into a
typecheck error (true not assignable to never) — the guarantee the task's
"add a status → all sites pick it up" verification criterion needs.

Coverage Stats

12362 of 17611 branches covered (70.19%)

Branch coverage included in aggregate %.

20 of 22 new or added lines in 10 files covered. (90.91%)

1 existing line in 1 file now uncovered.

105498 of 124052 relevant lines covered (85.04%)

299.45 hits per line