lsm / HyperNeo / 30775302639
83%

DEFAULT BRANCH: dev
Ran
Jobs 0
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
30775302639

push

github

web-flow 
feat(web): shape-based artifact rendering (ArtifactCard) (#796 PR B) (#2314)

* feat(web): render ArtifactCard by shape, with kind as icon/label

Replace the detectRenderer(data) data-shape sniffing (and the hardcoded
GITHUB_PR_RE GitHub-PR special-case) with a dispatch on artifact.artifactType,
which after the generic-shapes migration holds a value from the closed
ArtifactShape vocabulary.

Per-shape renderers: link (icon/label by data.kind — kind:'pr' is a PR row,
kind:'issue' an issue row, etc.), commit_set (commit list + +/- totals),
check (status chip + counts), metric (name value unit -> target), decision
(recommendation badge + summary/counts), note (status text line). A default
renderer handles any shape, known or not.

Tests now seed shape-typed artifacts instead of relying on data-shape
detection. TaskArtifactsPanel is unchanged — it already renders ArtifactCard.

Depends on the closed shape vocabulary from #2313 (PR A), included here as
commit 4e26d69 since PR A is unmerged.

* fix(web): address review — safe-URL links, commit_set guard, minimal-PR id, review evidence

Addresses the four review findings on #2314 (security P1 + three P2s):

1. Safe URL schemes (P1, security): LinkCard/CheckCard/DecisionCard now bind
   href only for http(s) URLs via safeHref(); agent-controlled javascript:/data:/
   custom-scheme URLs render as plain text. Defense-in-depth: validateArtifactShape
   ('link') also rejects non-http(s) URLs at save time.
2. commit_set crash guard (P2): filter null/non-object commit entries before
   dereferencing, so {commits:[null]} no longer throws and blanks the panel.
3. Minimal PR identifier (P2): a {url, kind:'pr'} link with no number/title now
   falls back to the URL as its label instead of a bare 'Pull Request'.
4. Legacy review evidence (P2): DecisionCard surfaces data.url/data.review_url as
   a 'review' link so review-history rows (mapped review->decision, carrying
   review_url not recommendation) are not rendered b... (continued)
Source Files on build 30775302639
Detailed source file information is not available for this build.