umputun / agterm / 30770898396

98%

push

github

fix: sanitize control chars in names and --cwd on the control/GUI paths (#347) (#354)

* fix: sanitize control chars in names and --cwd on control/GUI paths (#347)

A session/workspace/window name and a session --cwd flow unquoted into a
/bin/sh -c line via the {AGT_SESSION_NAME}/{AGT_SESSION_PWD}/{AGT_WORKSPACE_NAME}/
{AGT_WINDOW_NAME} custom-command tokens, so an interior newline (a statement
separator to sh -c) is a command-injection vector. The OSC path already enforces
this with TerminalText.sanitized; the control-socket and GUI rename paths ran the
value through trimmedOrNil only, which strips surrounding whitespace but leaves
an interior newline intact.

Sanitize in the four agtermCore store methods (renameSession, renameWorkspace,
renameWindow, addSession) so the control arms, the GUI rename and any future
caller are all covered and the tests stay host-free. Scope is the invisible
control-character vector only; visible shell metacharacters stay the caller's
concern via the quoted $AGT_X env form.

Fixes #347

* fix: sanitize the create-side name arms and the workspace lookup needle

Review follow-up: addWorkspace and newWindow are the create-side twins of
the rename arms fixed in the previous commit — workspace new --name,
session new --workspace-name --create-workspace, and window new --name
still carried an interior newline into {AGT_WORKSPACE_NAME}/{AGT_WINDOW_NAME}.

The lookup needle in workspace(named:) sanitizes too, and in that method
rather than ensureWorkspace: session.new --workspace-name without
--create-workspace calls workspace(named:) directly, so a needle-side-only
fix there would leave a raw needle against a sanitized stored name and read
back as a silent "workspace not found". Sanitizing before the blank gate
also keeps ensureWorkspace idempotent for control-char-only input (blank →
nil, not a fresh unmatchable workspace per call).

The sanitize tests move to AppStoreNameSanitizeTests.swift — the new arms
pushed AppStoreTests... (continued)

22 of 22 new or added lines in 3 files covered. (100.0%)

6909 of 7071 relevant lines covered (97.71%)

4252067.98 hits per line