coreui / coreui-pro / 30765886154

93%

main: 94%

push

github

fix(browserslist)!: declare the Firefox floor :has() already requires; make .alert-dismissible optional (#667)

Two changes, in that order because the second depends on the first.

1. The declared Firefox floor was fiction. We select with `:has()` in eleven
   places across five partials — validation and focus states on Multi Select
   and Autocomplete, the sidebar navigation indicators, calendar ranges, the
   rating icons — none of them behind `@supports`. Firefox shipped `:has()`
   in 121, while .browserslistrc claimed 120. That is not a graceful
   degradation: an unsupported `:has()` invalidates the entire rule it appears
   in, taking any sibling selector in the same list with it. The floor now says
   121, and both .browserslistrc and the browsers & devices page list which
   feature sets which floor, the way the light-dark() bound is already
   documented. Coverage: 87.19% -> 87.06%.

2. `.alert-dismissible` is no longer required. An alert holding a close button
   as a direct child now makes room for it and positions it on its own
   (`.alert:has(> .btn-close)`); the class stays supported for markup that
   already carries it, for buttons injected later, and for buttons nested in a
   wrapper. The close-button positioning keeps its descendant selector, so
   existing markup renders exactly as before.

Bootstrap v6 dropped the class by making .alert a flex container, which would
reflow every existing multi-block alert into a row; `:has()` reaches the same
result without touching the layout contract.

Verified in headless Chromium: alert without the class, with the class, with a
nested button and without any button all resolve to the right padding and
positioning.

4168 of 4709 branches covered (88.51%)

Branch coverage included in aggregate %.

8051 of 8435 relevant lines covered (95.45%)

337.7 hits per line