dangernoodle-io / breadboard / 30730519955

97%

push

github

fix: propagate bb_health section registration failures instead of discarding them (#1196)

bb_mqtt_client_health_register() and bb_temp_register_info() were both
void, discarding bb_health_section_register()'s bb_err_t with no log at
the call site. Their *_autoregister_init() wrappers additionally
hardcoded 'return BB_OK' regardless of the inner outcome. On the
bench, both producers failed with 'registry is frozen' and /api/health
kept returning 200 with zero section keys -- a degraded board looked
healthy.

Follows the pattern established by B1-1354 (PR #1187): change the
signature from void to bb_err_t and log (bb_log_e) at the call site on
failure, naming the specific section. The two *_autoregister_init()
wrappers now return their register function's real result instead of a
hardcoded BB_OK, so the existing aggregation in bb_app_init_rest()
(smoke) becomes live. floor_app.c's own return-value checks for these
two calls are dropped, not added to: the callee already logs the
failure by name, so a caller-side log would only repeat it; floor now
intentionally discards the two results (documented inline), same as it
and 8+ other in-tree call sites already discard bb_err_t returns
elsewhere with no compiler complaint (this repo has no
warn_unused_result anywhere) -- that gap is real and unaddressed here,
not retrofitted by this commit.

Host tests (test_bb_mqtt_client_health_section.c, test_bb_temp.c) force
bb_health_section_register() to fail via the existing
bb_health_section_freeze() seam and assert the error surfaces through
both the register and autoregister_init layers -- reverting the
propagation locally (both register functions and the mqtt wrapper) reproduces
the exact bug: three tests fail with BB_OK where BB_ERR_INVALID_STATE
was expected, restored after confirming.

B1-1370

8182 of 8746 branches covered (93.55%)

Branch coverage included in aggregate %.

11 of 11 new or added lines in 2 files covered. (100.0%)

13851 of 14006 relevant lines covered (98.89%)

2618.42 hits per line