valkyrjaio / valkyrja-starter-app-php / 30728461340
100%

DEFAULT BRANCH: 26.x
Ran
Jobs 1
Files 33
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
30728461340

push

github

web-flow 
[TestCase] fix: Stop passing the removed env argument (#219)

# Description

The framework removes `Valkyrja\Application\Env\Env` in
valkyrjaio/valkyrja-php#1109. The entry points drop their `$env`
parameter with
it. This pull request stops the starter app from passing that argument.

`app/tests/Tests/Functional/Abstract/TestCase.php` calls
`App::app(env: new Env(), config: new Config())`. After the framework
release
that call raises `Error: Unknown named parameter $env`.

The other entry points in this repository already pass `config:` only,
so this
one file is the whole change:

- `app/public/index.php`
- `app/bin/franken-worker.php`
- `app/bin/roadrunner-worker.php`

Note that no test currently extends this abstract test case. It is
scaffolding
for an application developer who writes functional tests, so this pull
request
repairs it rather than deletes it.

## Warning: this pull request is blocked

The released framework still declares the `$env` parameter, so this call
fails
until valkyrjaio/valkyrja-php#1109 merges and the framework releases.
Release
the framework first, then update this repository's lock.

Verified locally against the framework removal branch: 185 tests, 0
env-related
failures.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [x] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`app/tests/Tests/Functional/Abstract/TestCase.php`** — removed the
`Env`
  import and the `env:` argument from the `App::app()` call.

517 of 517 relevant lines covered (100.0%)

2.12 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30728461340.1 33
100.0
 GitHub Action Run
Source Files on build 30728461340