valkyrjaio / valkyrja-starter-app-php / 30728452555
100%

DEFAULT BRANCH: 26.x
Ran
Jobs 1
Files 33
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
30728452555

push

github

web-flow 
[Orm] fix: Rename the dated and soft delete entity traits (#220)

# Description

valkyrjaio/valkyrja-php#1108 renamed two ORM entity traits and their
fields. The
old names are gone from `26.x`, so this repository breaks the moment the
framework releases.

| Old | New |

|:------------------------------------------|:---------------------------------------------|
| `Valkyrja\Orm\Entity\Trait\Dateable` |
`Valkyrja\Orm\Entity\Trait\DatedFields` |
| `Valkyrja\Orm\Entity\Trait\SoftDeletable` |
`Valkyrja\Orm\Entity\Trait\SoftDeleteFields` |

`App\Orm\Entity\User` uses both traits. Against the framework `26.x`
branch the
test suite raises `Error: Trait "Valkyrja\Orm\Entity\Trait\Dateable" not
found`.

This repository does not name the renamed fields anywhere, so the traits
are the
whole change. The fields moved from `$date_created` and `$date_deleted`
to
`$created_at` and `$deleted_at`. An application that queries those
column names
directly has more work to do.

I found this while preparing the env removal for this repository
(#219). The two changes are unrelated, so they are separate pull
requests.

## Warning: this pull request is blocked

The released framework still ships the old trait names, so this change
fails
until the framework releases. Release the framework first, then update
this
repository's lock.

Verified locally against the framework `26.x` branch: 185 tests pass, 2
skipped
for missing server binaries.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [x] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`app/src/App/Orm/Entity/User.php`** — renamed the `Dateable` trait
to
`DatedFields` and the `SoftDeletable` trait to `SoftDeleteFields... (continued)

517 of 517 relevant lines covered (100.0%)

2.12 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30728452555.1 33
100.0
 GitHub Action Run
Source Files on build 30728452555