valkyrjaio / ci-phpunit-php / 30727536408
100%

DEFAULT BRANCH: 26.x
Ran
Jobs 1
Files 3
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
30727536408

push

github

web-flow 
[CopyrightHeader] ci: Enforce the license header under .github (#178)

# Description

Every PHP file under `.github` sat outside the license header rule. This
repository holds
6 such files, and each claimed `Valkyrja Framework`, which is not this
repository's
package. `COPYRIGHT_HEADER.md` in `valkyrjaio/.github` resolves this
repository to
`Valkyrja PHPUnit`.

The cause was not the `->exclude('.github')` call that the finder
carried. That call was
redundant. Symfony Finder sets `ignoreDotFiles(true)` by default, and
`.github` is a dot
directory, so the finder never descended into it either way. Removing
the exclusion alone
changes nothing, which was measured rather than assumed.

`->ignoreDotFiles(false)` is what brings those files into scope. This
pull request sets it,
and PHP CS Fixer then wrote the correct identifier into every file it
reached.

The redundant call dates to the commit that first created this
configuration, when no PHP
file existed under `.github` at all, so it never guarded anything.

This is one pull request in a cross-language batch that aligns every
copyright header in
the organization.

## Types of changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`.github/ci/phpcsfixer/.php_cs.dist.php`** —
`->ignoreDotFiles(false)` replaces
`->exclude('.github')`, so the finder reaches the PHP files under
`.github`.
`->exclude('.git')` is added, because a dot directory is no longer
skipped by default.
- **The remaining files under `.github/ci`** — the header now names
`Valkyrja PHPUnit`.
  Written by `composer phpcsfixer`, not by hand.

Every header in this repository now names `Valkyrja PHPUnit`... (continued)

33 of 33 relevant lines covered (100.0%)

3.24 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30727536408.1 3
100.0
 GitHub Action Run
Source Files on build 30727536408