valkyrjaio / ci-phpunit-php / 30726975596
100%

DEFAULT BRANCH: 26.x
Ran
Jobs 1
Files 3
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
30726975596

push

github

web-flow 
[TestCase] refactor: Remove the env singleton binding (#177)

# Description

`ServiceProviderTestCase::setUp()` binds a
`Valkyrja\Application\Env\Env`
singleton into the test container. No component reads `Env` any more.
The
fourteen component pull requests in `valkyrja/valkyrja` gave each
component a
typed config contract, and every service provider now reads that
contract.

This pull request removes the binding. It has to land first, because the
framework cannot delete `Env` while this package still constructs one.
The
framework loads this class from `vendor`, so `new Env()` would raise a
fatal
error in every provider test the moment the class is gone.

The binding is already dead weight for a consumer on the current
framework, so
removing it changes no behavior there.

Psalm's baseline held two `DeprecatedClass` suppressions. Both existed
only
because this class named the deprecated `Env`. The baseline is now
empty.

## Types of changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`src/PhpUnit/Abstract/ServiceProviderTestCase.php`** — removed the
`Env`
  import and the `Env` singleton binding from `setUp()`.
- **`.github/ci/psalm/psalm-baseline.xml`** — emptied the baseline. Its
only two
  entries suppressed the deprecation warning for `Env`.

33 of 33 relevant lines covered (100.0%)

3.24 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30726975596.1 3
100.0
 GitHub Action Run
Source Files on build 30726975596