bleedingdeacons / rabbit / 30721985839
65%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 17
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 47.776%. Remained the same
30721985839

push

github

web-flow 
chore(tests): test against Unity's real contracts, not a three-method copy (#27)

This suite eval()'d its own Unity interfaces — a Member with three of the
real twenty-three methods, and a MemberRepository with one of nine — on the
reasoning that "we only need the symbols to exist with the members
MemberMessenger actually touches".

The cost was that no double here could fail. FakeMember satisfied a contract
that was not Unity's, so a change to the genuine Member would have left this
suite green and fataled in production. Nothing checked the difference,
because there was nothing to check it against.

The bootstrap now registers a PSR-4 autoloader over ../unity/src — the
sibling checkout CI already arranges — so MemberMessenger is type-checked
against the real interfaces, and the doubles come from Unity\Testing\Doubles:

  - FakeMember and FakeMemberRepository are gone; MemberStub and
    InMemoryMemberRepository replace them. Members are built with named
    arguments now, since the shared stub's positional order is the
    interface's rather than this suite's three fields.
  - FakeContainer is gone too. Unity's implements Unity\Core\Interfaces\
    Container, which extends PSR-11, so it satisfies MemberMessenger's
    ContainerInterface type-hint. Its set() had no callers and nothing
    asserted on the RuntimeException it threw.

32 tests, 71 assertions before and after.

Scrutiny's AuditLogger is deliberately still stubbed here — Scrutiny ships no
doubles yet, and it should go the same way when it does.

247 of 517 relevant lines covered (47.78%)

2.38 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30721985839.1 17
47.78
GitHub Action Run
Source Files on build 30721985839