bleedingdeacons / reach / 30721977055
86%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 48
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 91.844%. Remained the same
30721977055

push

github

web-flow 
chore(tests): use the shared Unity test doubles (#44)

Unity now ships Unity\Testing\Doubles, so this suite stops maintaining its
own. Test counts are unchanged against baseline — 309 tests, 823 assertions,
6 deprecations, 50 skipped, before and after — so nothing has quietly stopped
being covered.

  - Five Member doubles become one. There was a named PwTestMember plus four
    anonymous classes inlined in the resolver, controller and OAuth-gate
    tests, each filling in the fourteen-odd accessors it did not care about
    and all agreeing on the same three defaults. Reach\Tests\Fixtures\MemberStub
    extends Unity's and keeps only those defaults: a member is a
    twelfth-stepper and is visible unless a test says otherwise, because the
    visibility gates are what most of these tests are about.
  - Four MemberRepository fakes become Unity's one. PwTestMemberRepository,
    GateTestMemberRepository, ControllerMemberRepository and a local
    InMemoryMemberRepository were the same class under four names, kept apart
    only so they could coexist in one PHPUnit run.
  - FakeContainer becomes Unity's, which additionally throws the real
    DependencyNotRegisteredException rather than a bare RuntimeException.
  - FakeMemberViewFactory moves to Reach\Tests\Fixtures. It stays local —
    Reach is the only plugin that fakes that contract — but it now autoloads,
    which lets ControllerRoutesTest drop two require_once lines that pulled in
    whole test files to reach a class at the bottom of them.

The bootstrap now registers a PSR-4 autoloader over ../unity/src (UNITY_PATH
still overrides) instead of requiring three named interface files. Its eval()
fallback — a hand-written copy of Member, MemberRepository, Container,
MemberViewFactory and ResponderCertification — is gone. It never ran in CI,
which always checks Unity out, so nothing would have caught it going stale;
its own comment already conceded that "tests that rely on richer Unity
behaviour shou... (continued)

2331 of 2538 relevant lines covered (91.84%)

6.19 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30721977055.1 48
91.84
GitHub Action Run
Source Files on build 30721977055