valkyrjaio / valkyrja-php / 30719206477

100%

push

github

[Crypt] feat!: Configure the crypt component with a typed config contract (#1003)

# Description

`Valkyrja\Application\Env\Env` is deprecated. It is one non-final class
that holds
about 120 `public const` env variables for every component at once. This
pull
request gives the Crypt component its own typed config contract and its
own config
class. It also converts `CryptServiceProvider` to read that contract.

`CryptServiceProvider` no longer reads `Env`. An application that sets
`Env::CRYPT_DEFAULT` loses that setting, so this change breaks a public
contract.

This pull request does not change `Env.php`. Each component gets its own
pull
request, and all of those pull requests are independent. A pull request
that
deleted its own constants would conflict with every sibling pull request
on that
one file. `Env` therefore stays in place and goes unread. A later pull
request
removes the whole class.

The shape follows `Cli\Interaction`, and it matches the sibling pull
request for
the Cache component:

- `CryptConfigContract` is the container binding key. The application
can
implement the contract on its own `Config` class. `publishConfig` then
binds
  that object.
- `CryptConfig` is the default. `publishConfig` binds a new instance
when the
  application config does not implement the contract.

The Crypt component reads one env constant, so the config class holds
one
property and needs no nested adapter config.

`publishSodiumCrypt` still reads `key` from the application config. That
key is an
application-level value, not an env constant, so this pull request
leaves it where
it is.

Sibling pull requests: #1002 (Cache).

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [x] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [x] Breaking change _(fix or feature that would cause existing
fu... (continued)

17 of 17 new or added lines in 2 files covered. (100.0%)

12606 of 12606 relevant lines covered (100.0%)

23.77 hits per line