valkyrjaio / valkyrja-php / 30718780846

100%

push

github

[Session] fix: Rename SmsServiceProvider to SessionServiceProvider (#1005)

# Description

The Session component's service provider carried the Sms component's
name. The file
`src/Valkyrja/Session/Provider/SmsServiceProvider.php` declared
`namespace Valkyrja\Session\Provider;`
and `class SmsServiceProvider`. A copy of
`src/Valkyrja/Sms/Provider/SmsServiceProvider.php` created
the wrong name.

The class registers Session services only. Its 16 publishers bind
`SessionContract`, `PhpSession`,
`NullSession`, `CacheSession`, `CookieParams`, and the other session
managers. No publisher binds an
SMS service. The sibling file in the same directory is already correct:
`SessionComponentProvider.php`.

The wrong name breaks the provider naming rule in `AGENTS.md` §4. A
provider takes the form
`ComponentName[SubComponent]TypeProvider`. The recursive uniqueness rule
exists because the generated
data-cache file references providers from many components at the same
time. Two classes named
`SmsServiceProvider` can collide there. This change removes the risk,
because `SmsServiceProvider`
now names one class only.

This change renames the class and deletes the old name. It adds no
deprecated alias. An alias keeps a
second `SmsServiceProvider` in the tree, which is the collision that the
uniqueness rule prevents. The
risk to an application is small. The old name describes a component that
the class does not serve, so
an application is unlikely to register the old name directly.

PHPArkitect does not catch this error. The taxonomy rules check the
`*ServiceProvider` name suffix and
the `Provider\` segment. The rules do not check the component-name
prefix. PHPArkitect passed before
this change and after it.

The Java port and the TypeScript port do not have the Session component
or the Sms component. This
change applies to PHP only.

The full CI gate passes. Line coverage and branch coverage stay at 100%.

## Types of changes

- [ ] Improvement _(non-breaking change which ... (continued)

1 of 0 new or added lines in 0 files covered. (NaN%)

12596 of 12596 relevant lines covered (100.0%)

23.78 hits per line