dangernoodle-io / breadboard / 30704714615

97%

push

github

fix: init-marker-gated-srcs lint misses in-file Kconfig-gated definition bodies (B1-1347) (#1181)

- extend init-marker-gated-srcs to catch a // bbtool:init marker's fn whose SRCS entry is unconditional but whose definition BODY is wrapped in an in-file #if/#ifdef keyed on a Kconfig CONFIG_* symbol, with no unconditional/terminal-#else fallback in that file -- the real bb_mqtt_client_init_default shape (SRCS unconditional, body gated on CONFIG_BB_MQTT_CLIENT_AUTOREGISTER, now-removed on main)

- rule: a gating condition containing a CONFIG_* token blocks (board-flippable sdkconfig knob); a condition matching the explicit _SAFE_GUARD_RE allowlist (ESP_PLATFORM/ARDUINO/__AVR__/an in-tree *_TESTING build-mode macro) never blocks -- neither is a knob a board's sdkconfig can turn off, both are structurally fixed for the backend TU/build mode the file already belongs to; EVERYTHING ELSE (an unrecognized/opaque condition, e.g. #if 0 or a typo'd Kconfig symbol) blocks by default, same as a Kconfig frame -- review MEDIUM caught a first cut that inverted this (treated not-CONFIG_* as safe instead of an explicit allowlist), which silently exempted #if 0 and a mistyped CONFGI_BB_FAKE_AUTOREGISTER; both now fire, verified empirically by re-running the two regression tests against the pre-fix mask (b0caa606) and capturing the failure

- generalize the header-#else-stub trust mask (_preproc_trusted_line_mask) into the new Kconfig-scoped _preproc_kconfig_gate_mask, fixing a latent false positive this change would otherwise have exposed: bb_ota_boot.h/bb_ota_pull.h's real Kconfig-bridge #else stubs sit nested inside a no-#else #ifdef ESP_PLATFORM guard, which the old fully-generic mask treated as untrusted forever

- review LOW: _has_trusted_header_stub/_definition_kconfig_gate docstrings now state the three-way (Kconfig/allowlisted/opaque) classification, not just the two-way split; the opaque-condition violation message no longer uses the disabling-X/when-X-is-off f... (continued)

8101 of 8674 branches covered (93.39%)

Branch coverage included in aggregate %.

13740 of 13895 relevant lines covered (98.88%)

2571.69 hits per line