dangernoodle-io / breadboard / 30689651483

97%

push

github

refactor: remove BB_MQTT_CLIENT_AUTOREGISTER knob (B1-1331) (#1180)

Composition knobs die per northstar; wiring is codegen-or-handwire
only, never a self-registration Kconfig toggle. The knob was
default y with nothing overriding it anywhere in-tree (checked
sdkconfig.defaults*, *.ini, CI workflows), so removal is a runtime
no-op in-tree.

This also closes a latent build break (B1-1347): the bbtool:init
marker, the function declaration, and the function definition were
all guarded by CONFIG_BB_MQTT_CLIENT_AUTOREGISTER, but codegen scans
marker text and emits the bb_mqtt_client_init_default() call
unconditionally from it, regardless of the guard around the marker
itself. The Kconfig help text explicitly invited setting the knob
to n to call bb_mqtt_client_init manually, but doing so would not
have built (implicit-declaration, then undefined-reference).
Reproduced pre-fix on a scratch sdkconfig override: setting
CONFIG_BB_MQTT_CLIENT_AUTOREGISTER=n produced exactly this
implicit-declaration error; post-fix there is no such symbol to set,
so the failure mode is structurally gone.

Note three sibling functions (stop_default/suspend_default/
resume_default) had a disabled-case no-op stub for when the knob was
n, but bb_mqtt_client_init_default -- the one function codegen
actually calls -- did not.

di_legacy fence baseline shrinks 15 -> 12 markers (one
autoregister_kconfig, two autoregister_usage entries pruned,
--update-baseline, shrink-only).

8101 of 8674 branches covered (93.39%)

Branch coverage included in aggregate %.

13740 of 13895 relevant lines covered (98.88%)

2647.78 hits per line