stillwater-sc / universal / 30681506242

85%

master: 84%

Build Type

push

github

Committed by web-flow

Commit Message

fix(cfloat): clear -Wsign-conversion in cfloat + blocktriple (#1282) (#1287)

* fix(cfloat/blocktriple): clear -Wsign-conversion (#1282)

Sub-issue of Epic #1279. Six sites, all value-preserving:

blocktriple.hpp roundingDecision (299-300): `shift + adjustment` mixes
unsigned `shift` with int `adjustment` (subnormal adjustment). adjustment
was already implicitly converted to unsigned; make it explicit
(`shift + static_cast<unsigned>(adjustment)`) -- bit-identical.

cfloat_impl.hpp:
- setsign (1268): `~SIGN_BIT_MASK` promotes the narrow bt mask to int
  (value-changing for uint8/uint16 limbs); cast the complement back to bt
  before the &= -- the retained low bits are identical.
- convert_signed_integer (2543): `sizeInBits - exponent - 1` with int
  exponent (msb of a nonzero value, so 0 <= exponent < sizeInBits) -> cast
  exponent to uint32_t; exact since non-negative and in range.
- subnormal convert (2940): the sticky-bit mask shift count is now computed
  in signed int (`static_cast<int>(fbits) + exponent + ...`), matching the
  sibling areal code; exponent < 0 on this path, and the sum is a valid
  small shift count. Same value, no unsigned wrap of the int operands.
- to_string(value, precision) (3534): `lsbScale = scale - fbits` is negative
  whenever |scale| < fbits, and a raw size_t cast would spin powerOf2 ~2^64
  times. Guard the conversion (clamp negative to 0) before casting -- fixes
  a latent hang as well as the warning. (This legacy overload is superseded
  by the blocktriple-based operator<< and is already lossy for fractional
  values; out of scope to rewrite here.)

Verified -Wsign-conversion clean on gcc AND clang (no new -Wconversion);
blocktriple rounding/addition/api, cfloat integer_conversion/
ieee754_subnormals/assignment, and cfloat subnormal addition+multiplication
(REGRESSION_LEVEL_1) PASS on both; guarded to_string no longer hangs on
fractional inputs.

Relates to #1279
Resolves #1282

Co-Authored-By: Claude Opus 4.8 (1M con... (continued)

Coverage Stats

4 of 5 new or added lines in 2 files covered. (80.0%)

8 existing lines in 1 file now uncovered.

41710 of 48936 relevant lines covered (85.23%)

7271778.77 hits per line