decentraland / lamb2 / 30680118127

63%

main: 63%

Build Type

Pull #471

github

Committed by LautaroPetaccio

Commit Message

fix: batch definitions too and bound the pointer request fan-out

extract the batching into a shared helper so wearable and emote definitions
stay under the content server pointers limit as well. definitions are
resolved for every owned item at once, so /collections/wearables-by-owner/
:owner?includeDefinitions answered 500 for the same wallets as
/explorer/:address/wearables.

bound the concurrency of the batched requests. the 1000-pointer cap exists
to keep the underlying query cheap on a public endpoint, so a wallet with
many items must not fan one request out into an unbounded burst of them.

a failing batch now costs its own entities instead of the whole response,
since callers already treat an unresolved pointer as a miss.

raise the batch size to 900 and export it, so the tests assert against the
constant instead of duplicating it.

the profiles path is left unbatched on purpose: its handler already rejects
more ids than the content server accepts, and batching it would turn a hard
failure into silently partial profiles. the cap now documents the coupling.

Pull Request Pull Request #471: fix: batch entities requests to stay under the content server pointers limit

Coverage Stats

462 of 970 branches covered (47.63%)

Branch coverage included in aggregate %.

30 of 32 new or added lines in 3 files covered. (93.75%)

21 existing lines in 3 files now uncovered.

1645 of 2381 relevant lines covered (69.09%)

76.7 hits per line