valkyrjaio / valkyrja-php / 30679781743
100%

DEFAULT BRANCH: 26.x
Ran
Jobs 1
Files 1138
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
30679781743

push

github

web-flow 
[Http] test: Point the remaining uploaded file tests at storage paths (#996)

# Description

PR #990 fixed a test that left an untracked, zero-byte file named `test`
in the
repository root. The cause was a bare relative path: `UploadedFile`
opens its file with
the `w+b` mode, which creates the file when it does not exist, so a path
such as
`'test'` resolves against the PHPUnit working directory — the repository
root.

Fifteen more call sites still pass such a path. None of them reaches the
code that
opens the file today, so none of them writes anything, and the working
tree stays
clean. They remain a trap: the next test that calls `getStream()` or
`moveTo()` on one
of these objects puts a file back in the repository root, where a `git
add -A` commits
it silently.

This PR removes the trap. Every remaining call site now takes its path
from
`Directory::storagePath()`.
`Valkyrja\Tests\Abstract\TestCase::tearDown()` empties that
directory after each test, and the directory ignores its own contents,
so a file that
does get created can neither survive the test nor reach a commit.

The two fixtures that force a failure do so regardless of the path —
`InvalidDirectoryExceptionFixture` returns false from `isDir()`, and
`UnableToWriteFileExceptionFixture` returns false from `openStream()`.
Their `moveTo()`
targets therefore move to storage paths as well without weakening the
assertions.

Values that are not paths keep their previous content. The `fileName`
argument in
`testGetClientFilename` and the `mediaType` argument in
`testGetClientMediaType`
describe the client's upload, not a location on disk.

## Types of changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
... (continued)

12596 of 12596 relevant lines covered (100.0%)

23.78 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30679781743.1 1138
100.0
 GitHub Action Run
Source Files on build 30679781743