valkyrjaio / valkyrja-php / 30679778977

100%

push

github

[Orm] fix: Correct the malformed DSN strings built by the service provider (#995)

# Description

`OrmServiceProvider` builds the DSN it hands to PDO from an interpolated
string. Two
characters in that string are wrong, so every DSN the provider builds is
malformed.

The first fault is a stray closing brace after the database name. All
three builders
carry it:

```php
$dsn = 'mysql'
    . ":dbname=$db}"   // the brace is not part of the database name
    . ";host=$host"
```

The brace makes the database name `valkyrja}` instead of `valkyrja`. It
looks like a
leftover from a `{$db}` to `$db` edit.

The second fault is in the pgsql builder alone. The `options` value
opens a quote and
never closes it:

```php
. ";options='--client_encoding=$charset";
```

PostgreSQL expects the value in the form
`options='--client_encoding=UTF8'`.

No test caught either fault. Every test that reaches these builders
replaces PDO with
a fixture, so the DSN passed to it was never read. This PR adds a test
per builder
that captures the DSN and compares it to the full expected string, so
any later change
to the format must be deliberate.

Both faults reach a real connection attempt only when an application
publishes one of
these managers, so no test suite in this repository connects with the
broken DSN.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [x] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`src/Valkyrja/Orm/Provider/OrmServiceProvider.php`** — removed the
stray `}` after
the database name in the mysql, pgsql, and sqlite DSNs, and closed the
quote around
  the pgsql `client_encoding` option.
- **`tests/Tests/Unit/Orm/Provider/ServiceProviderTest.php`** — ... (continued)

4 of 4 new or added lines in 1 file covered. (100.0%)

12596 of 12596 relevant lines covered (100.0%)

23.78 hits per line