lsm / HyperNeo / 30664503433

83%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(space): make task lifecycle the only external-event delivery gate (#2289)

* refactor(space): make task lifecycle the only external-event delivery gate

External-event delivery previously mixed three concerns: subscription
lifetime, workflow-run execution-attempt status, and target availability.
That caused subscribed events to disappear when a run finished, rejected a
blocked run with no execution as run_not_externally_deliverable, and
prevented a PR CI check_failed from reactivating accepted work after the
run/session ended.

Refactor so the owning task is the only lifecycle authority:

- Add prepareExternalEventTask: the single task-owned decision used by fresh
  matches, queued flushes, activation/session retries, rate-limit digests,
  and requeue sweeps. cancelled/archived tasks fail as target_task_terminal;
  a done task fails non-reactivating events the same way but reactivates
  (recoverWorkflowBackedTask) for a normalized GitHub PR check_failed.
- Remove run-status delivery gates (isExternallyDeliverableRun,
  run_not_externally_deliverable, blocked_run_gate_not_opened). Run status
  never vetoes a task-owned event; a blocked run or missing execution is an
  availability condition, not a failure.
- Detach subscription lifetime from run completion: terminal run transitions
  and executor cleanup no longer clear PR auto-subscriptions. Cleanup is
  task-owned (cancelled/archived task) and space-owned (archive/delete),
  wired via the space.task.updated onTaskUpdated callback and bus subscriber.
- Rebuild task-owned PR subscriptions for any eligible task (including done)
  on tick sweep, rehydrate, and space resume, before pending-delivery replay.
- Add a synchronous evaluateRequeueTaskLifecycle so restart/resume sweeps
  terminalize deliveries for cancelled/archived/done tasks immediately
  instead of leaving them pending; reactive check failures still requeue.

Update focused tests to the task-owned model (cancelled/blocked/done runs
n... (continued)

Coverage Stats

11687 of 16768 branches covered (69.7%)

Branch coverage included in aggregate %.

635 of 800 new or added lines in 4 files covered. (79.38%)

2 existing lines in 1 file now uncovered.

100184 of 118531 relevant lines covered (84.52%)

302.73 hits per line