dangernoodle-io / breadboard / 30662265941

97%

push

github

refactor: drop bb_http_server from bb_system's public REQUIRES (#1162)

Carve the route declarations (bb_system_routes_reserve/_init, the request
schema, and the BB_SYSTEM_TESTING-gated test accessors) plus their two
// bbtool:init markers out of bb_system.h into a new co-located
bb_system_routes.h, matching the bb_storage_http.h/bb_log_http.h precedent
bb_system.h's own comment already cited but didn't follow.

bb_http_server moves from bb_system's public REQUIRES to PRIV_REQUIRES
(components/bb_system/CMakeLists.txt) -- bb_system.h no longer needs it,
and bb_system_snap.h never did. That is the whole of this commit's effect:
consumers of the reboot-reason SSOT, boot banner, boot-fail counters and
bb_system_snap no longer inherit a public dependency edge on
bb_http_server.

## What this does NOT do

It does not stop a codegen consumer from getting POST /api/reboot.

An earlier framing of this change claimed it would. That was wrong, and the
generated output proves it: scripts/bbtool/commands/wire.py globs every *.h
under a composed component's include/ directory, so moving markers into a
sibling header inside the SAME component changes nothing about what codegen
emits. Regenerating examples/floor and examples/smoke still calls both route
entrypoints; the only diff is one added `#include "bb_system_routes.h"` line
-- the correct consequence of the markers changing files, and simultaneously
the evidence that no decoupling occurred.

Composing bb_system therefore still force-registers POST /api/reboot. That
is a real defect -- a component choosing the consumer's exposed HTTP surface
-- and it is tracked as epic B1-1314, which makes route-registering markers
(server=true / registers_routes=true) manifest-only so a consumer must name
the routes it wants. Header location is irrelevant under that model; this
commit is kept purely for the dependency-edge reduction above.

## Config-gate hazard: latent, not live

CONFIG_BB_SYSTEM_ROUTES_AUTOREGISTER gates whe... (continued)

8092 of 8668 branches covered (93.35%)

Branch coverage included in aggregate %.

13719 of 13874 relevant lines covered (98.88%)

2584.38 hits per line