dangernoodle-io / breadboard / 30604727579

97%

push

github

refactor: extract shared bb_system_restart_deferred primitive (#1161)

Two committed sites hand-rolled the identical lazily-created static
oneshot-timer + deferred restart idiom: bb_wifi.c's bb_wifi_reconfigure
and examples/floor's provisioning-is-transient reboot. Both now arm
the new bb_system_restart_deferred(src, detail, delay_us), deleting
their private work_fn + static-timer boilerplate.

- one shared static oneshot timer for the whole process, lazily created
- the pending src/detail statics and the timer (re-)arm are guarded by
  an internal bb_lock_t (lazily bb_lock_init()'d via bb_lock_once_ensure,
  same idiom as bb_lifecycle.c) -- both the arm() write path and the
  fire callback's read path take the lock, since a fire already
  dequeued off the shared timer-dispatch task can race a concurrent
  arm() call
- accepted caveat: two causes arming within the same window still
  collapse to last-arm-wins -- synchronization only rules out a torn/
  corrupted detail string, not which caller's write lands last
  (documented on the new function)
- host-tested via a BB_SYSTEM_TESTING capture seam (mirrors
  bb_system_routes.c's reboot_handler pattern), since the real
  bb_system_restart_reason() call exit(0)s the host test process; a
  dedicated lock-stats-based test proves the lock is genuinely
  acquired on both the arm and fire paths


Claude-Session: https://claude.ai/code/session_0119nuE2NZME9y2aYEVJTPB5

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

8092 of 8668 branches covered (93.35%)

Branch coverage included in aggregate %.

43 of 43 new or added lines in 1 file covered. (100.0%)

13719 of 13874 relevant lines covered (98.88%)

2574.07 hits per line