decentraland / comms-gatekeeper / 30655110208

86%

main: 85%

Build Type

Pull #283

github

Committed by LautaroPetaccio

Commit Message

docs: record why the cluster access checks fail open

Raised in review as a P1. The behaviour is a deliberate product decision, not
an oversight: an outage in the connection-info read, the ban store or the deny
list must not stop island formation, because that leaves players unable to get
into voice at all. Availability is judged the more important property here.

Documents what it costs (a banned or deny-listed wallet can be minted a token
while a lookup is failing), what bounds it (banning clears live rooms at ban
time, and the result is not cached so the next event retries), and why this
path differs from the signed-fetch HTTP path, where a deny-list error still
rejects the request.

Pull Request Pull Request #283: feat: mint LiveKit island rooms from Pulse cluster feed (Archipelago ⇒ Pulse, iteration 1)

Coverage Stats

1196 of 1512 branches covered (79.1%)

Branch coverage included in aggregate %.

232 of 0 new or added lines in 0 files covered. (NaN%)

29 existing lines in 3 files now uncovered.

3304 of 3709 relevant lines covered (89.08%)

76.73 hits per line