enbility / spine-go / 30638305198

93%

push

github

fix(model): merge nested pointer-to-struct fields in updateFields (#103)

## Summary

`updateFields` in `model/collection_operations.go` only checked whether
a
field's pointer itself was `nil` before deciding to copy a value from
the
existing entry. For nested struct pointers (e.g.
`LoadControlLimitDataType.Value
*ScaledNumberType`) this meant: if the incoming partial write set
`Value` to a
non-nil pointer but left an inner field like `Scale` as `nil` (i.e.
omitted),
that inner field was never merged and stayed `nil` instead of being
preserved
from the existing entry.

Fix: split `updateFields[T]` into a thin generic wrapper and a new
non-generic `updateFieldsValue(remoteWrite bool, sV, dV reflect.Value)`
that
does the actual field-by-field merge. When both source and destination
carry
a non-nil pointer to a struct, `updateFieldsValue` now recurses into
that
struct instead of stopping at the outer pointer. Recursion has to happen
through a non-generic helper because Go generics can't infer `T` again
once
the nested value has been unwrapped via reflection.

Closes #97
Related to #94

## Testing

- Added `model/rfe_scaled_number_test.go`:
- `TestRFE_ScaledNumberType_OmitScale_PreservesExisting` — direct merge
without partial filter
- `TestRFE_ScaledNumberType_PartialFilter_OmitScale` — merge via partial
filter selector
- `go test -v ./model -run TestRFE_ScaledNumberType -count=1` passes
- `go test -v ./model -count=1` passes (existing
`collection_operations_test.go` suite unaffected)

10 of 10 new or added lines in 1 file covered. (100.0%)

6178 of 6655 relevant lines covered (92.83%)

25109.47 hits per line