enbility / spine-go / 30638253918

93%

push

github

fix: reject bindings targeting the NodeManagement feature (TC_SPINE_BIND_001) (#100)

Closes #95. Contributes to #94 (SPINE TestSpecification V1.0.0
compliance).

Fixes **TC_SPINE_BIND_001** / [SPINE-TS-BIND-01] from the SPINE
High-Level Test Specification.

## Problem

A binding request targeting the local primary NodeManagement feature
(entity 0 / feature 0) must be rejected with a NACK, and no binding
entry may be created for it. `AddBinding` whitelisted `RoleTypeSpecial`
(which NodeManagement uses) via `checkRoleAndType`, so such a request
passed, an entry was persisted, and `HandleMessage` returned no error →
the device sent `ResultSuccess` (ACK). A subsequent
`nodeManagementBindingData` read then exposed a `bindingEntry` with
`serverAddress.entity=0/feature=0`.

Contrast: `subscription_manager.go` has the same Special exemption,
which is spec-correct there (TC_SPINE_SUBS_001 requires NodeManagement
subscriptions be accepted). Binding requires the opposite; the deny
logic was simply absent.

## Fix

Reject in `AddBinding` when the local server feature is NodeManagement →
the request now returns an error → NACK, and no entry is created.

## Test

`Test_Bindings_RejectNodeManagement` asserts the request errors and no
binding is registered. Full `spine` suite passes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

3 of 3 new or added lines in 1 file covered. (100.0%)

6172 of 6649 relevant lines covered (92.83%)

25449.63 hits per line