kiva / ui / 30626465983

84%

push

github

fix: repair error handling defects found while auditing logFormatter (#7119)

None of these are logFormatter misuse; they are bugs found in the same catch
blocks while auditing call sites.

- basketUtils: `scope.setTag('loan_id', this.loanId)` in a plain module function.
  `this` is undefined under ESM strict mode, so it threw on the first setTag and
  Sentry.captureException on the next line never ran, with the outer
  `catch { // no-op }` hiding it. Set-lend-amount errors have never reached
  Sentry.
- useGoalData: `response.data.userAchievementProgress` was unguarded, so a
  response without data threw a TypeError and the catch logged that instead of
  the real query failure.
- useBorrowerProfileData: a `.then()` with no `.catch`, where the enclosing
  try/catch cannot catch the rejection.
- EmailSettings: `errors[0].extensions.code` unguarded at three sites, able to
  throw inside the `throw` and mask the real error.
- borrower-profile-exp-mixin, ProcessInstantLending: unguarded `error.message`
  inside no-op catch blocks, skipping the Sentry capture that follows.
- CCLandingPage: an Error object was assigned to promoErrorMessage, which is
  rendered; every other assignment stores `errors[0].message`.
- OrderTotals: a raw console.error bypassed the structured log format.
- ProcessInstantLending: removed a stray console.log.

Log calls use the existing logFormatter(e, 'error') shape, matching the rest of
this repo and cms-page-server.

6442 of 7206 branches covered (89.4%)

Branch coverage included in aggregate %.

5 of 11 new or added lines in 6 files covered. (45.45%)

53513 of 64022 relevant lines covered (83.59%)

28.95 hits per line