Ghini / ghini.desktop / 30614527883

58%

master: 62%

Build Type

push

github

Committed by Mario Frasca

Commit Message

fix(db): declare attributes expected by Serializable/DefiningPictures mixins

Serializable.__table__, DefiningPictures.notes, and the dynamically
built Note classes from make_note_class() all relied on attributes
supplied only by whatever class they're mixed into, with nothing
declared on the mixins themselves. mypy flagged every access as
attr-defined.

- Serializable: declare __table__ as ClassVar[Table]; add a `retrieve`
  classmethod that raises NotImplementedError by default, matching the
  existing pattern for correct_field_names/compute_serializable_fields
  (previously undeclared, silently assumed to be supplied elsewhere).
- DefiningPictures: declare `notes` as ClassVar[Sequence[Any]].
- TypedBaseMixin: declare `order_by` as ClassVar[Optional[Sequence[Any]]]
  instead of relying on hasattr() duck-typing.
- make_note_class: cast the type()-constructed class to type[Base]
  before setting order_by/__table__-derived defaults.

No behavior change for existing subclasses, which already supply all
of these; the one exception is a hypothetical subclass that omits
`retrieve` entirely, which now fails with a clear NotImplementedError
instead of a confusing AttributeError.

Coverage Stats

10 of 11 new or added lines in 1 file covered. (90.91%)

59 existing lines in 2 files now uncovered.

13023 of 22302 relevant lines covered (58.39%)

0.58 hits per line