wol-soft / php-json-schema-model-generator / 30602842852

99%

master: 99%

Pull #166

github

Add tests covering PR #166's coverage gaps and regressions

Coveralls flagged 12 uncovered lines across SchemaProcessor.php,
PropertyFactory.php, and ObjectShapeResolver.php, plus 2 coverage
regressions in AbstractComposedPropertyValidator.php and
SchemaProcessor.php. Add characterization/unit tests reaching each:

- A root-level oneOf whose last branch is a literal `true` schema
  element (the only branch shape that avoids type inheritance at a
  class boundary) drives the new vacuous-branch path in
  SchemaProcessor and its finalize-completion body.
- An unresolvable $ref inside an allOf branch drives the
  catch(Throwable) in PropertyFactory::resolveObjectShape()'s
  speculative classification peek, and confirms the same broken
  reference is still reported cleanly by the real resolution
  afterward.
- Empty anyOf/oneOf arrays drive ObjectShapeResolver's
  combineDisjunctive([]) arm.
- A oneOf on a NAMED property (not the schema root) with an
  object-typed branch drives AbstractComposedPropertyValidator's
  scopeProperty===null guard, whose only prior test coverage came
  from a since-fixed under-recognition bug rather than the guard's
  actual intended (named-property) scenario.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015kJ3xjHFogftRV4m2ukJFN

206 of 206 new or added lines in 8 files covered. (100.0%)

7344 of 7431 relevant lines covered (98.83%)

578.49 hits per line