kiva / ui / 30570407209

84%

push

github

fix(logFormatter): stop losing caught errors, and fix 17 wrong-level calls (#7118)

* fix(logFormatter): unwrap Errors so failures are not lost

An Error's message and stack are non-enumerable, so JSON.stringify reduced a
caught Error to `{}` and the failure was unrecoverable from the log. Reduce
Errors to their message, in the message slot and inside meta.

This brings kiva/ui in line with cms-page-server, whose logFormatter already
does the same (`message.message ?? message`), so `logFormatter(e, 'error')`
behaves identically in both repos.

Level handling is unchanged: an unrecognised type still logs as a plain log
rather than being escalated. All 15 existing tests pass untouched.

* fix(logFormatter): pass a level, not a description, at 17 call sites

These calls put the failure description in the level slot, so it matched no case
in the switch and fell through to console.log. The errors went to stdout at log
level and never reached error alerting.

    - logFormatter(error, 'Failed to fetch loan stats by year');
    + logFormatter('Failed to fetch loan stats by year', 'error', { error, year });

Two ThanksPage calls passed 'warning', which is not a level either; 'warn' is.

This is a bug rather than a call format: cms-page-server cannot have it because
its LogLevel is a typed union, so nothing here diverges from that repo.

Descriptions in useGoalData were already prose and are unchanged. The eight in
KvAtbModalContainer, BailoutChips and useMyKivaHome named a query or a composable
rather than the failure, so they now say what failed.

* fix(logFormatter): log a fallback message when only meta is present

A call with no message returned early, discarding the level and any meta with
it. That is the same information loss this change set exists to fix, so fall
back to '(no message)' when meta has content and bail only when there would be
nothing at all to record.

A call with neither a message nor meta still returns false, so the three
existing guar... (continued)

6444 of 7207 branches covered (89.41%)

Branch coverage included in aggregate %.

46 of 51 new or added lines in 6 files covered. (90.2%)

53827 of 64465 relevant lines covered (83.5%)

28.77 hits per line