umputun / agterm / 30528733547

98%

push

github

refactor: apply the comment brevity rule across the repo (#323)

* test: cut comment restatement from the five densest test files

Applies the CLAUDE.md test-comment rule to the first batch: step narration
and comments that restate the test name are gone, fixture facts stay as one
line each.

What survives is what the code cannot say - tee blocking on the pty so the
foreground is not the prompt, /private canonicalization under /tmp, the
promoted split survivor being the main pane now, acceptsFirstResponder
blocking only new grabs and never a held one, and why the dashboard focus
test deliberately avoids the openDashboard helper that would mask its race.

298 comment lines removed across five files. 2042 tests still pass.

* test: apply the comment brevity rule to the remaining test files

Second and final batch, 101 files. Step narration, arrange/act/expect
commentary and assertions annotated with what they assert are gone; the
fixture facts stay as one line each.

What survives is what a reader cannot recover from the code: 400 four-byte
scalars being under the cap by grapheme count and over it by bytes, AppKit
matching an uppercase key equivalent against the shifted chord, a disabled
menu item consuming its key equivalent and firing nothing, dedup running
before the limit cut so prefix-then-dedup would yield a different answer,
XCUITest still enumerating a minimized window's AX tree so palette
visibility is not a foreground oracle, and the socket path having to sit
under the 104-byte sun_path limit AND inside the runner sandbox.

1513 comment lines removed. 2042 host-free tests pass, the test bundle
builds, swiftlint is clean. The diff is comment-only: every changed code
line differs from its counterpart solely in a stripped trailing comment.

* refactor: tighten Swift source comments to what the code cannot say

Two passes over 154 source files. The first deleted pure restatement and
removed only 159 lines; the second compressed verbose comments, p... (continued)

191 of 191 new or added lines in 21 files covered. (100.0%)

6543 of 6716 relevant lines covered (97.42%)

4476802.16 hits per line