dangernoodle-io / breadboard / 30507223967

97%

push

github

feat: fold manifest component= into the composition closure (#1141)

- add optional component=<name> field to // bbtool:init markers, valid only on a --consumer-manifest marker (wire_parse.py grammar)
- codegen.run() parses the manifest before composition resolution and folds named component(s) into the SAME boards.resolve_transitive closure walk [capability.*].components feeds, including transitive REQUIRES/PRIV_REQUIRES
- unknown/misspelled component= names fail loudly, naming both the component and the manifest file
- component= on a marker grepped from a component header (collect_entries) is rejected as a hard WireError -- a component header already has an owning component; allowing it would be unreviewed implicit composition
- absent component= leaves output byte-identical to today
- hard-error (ManifestError) when a manifest's component= pulls in a component the resolved board excludes via its own remove_components -- scoped to the closure DELTA the manifest fold introduces (full_closure - base_closure), so a board's pre-existing, already-valid transitive re-pull of a removed component (via its own capability set) is never newly flagged; covers both a component named directly and one only reachable transitively through a named component's own REQUIRES/PRIV_REQUIRES, reporting the requires-chain (e.g. bb_target -> bb_target_dep) for the transitive case; the fix is to edit the board's remove_components, never an override escape hatch
- document + regression-test the wire_names/names aliasing in codegen.run() that keeps a manifest-named component's own '// bbtool:init' markers from being scanned (only the manifest entry's own marker gets wired)
- document the field in scripts/bbtool/README.md and the wiki Codegen page

7916 of 8520 branches covered (92.91%)

Branch coverage included in aggregate %.

13480 of 13635 relevant lines covered (98.86%)

2610.63 hits per line