stores-com / bloodhound / 30507252727

86%

main: 88%

Pull #175

github

test: serialize every test that shares the globalThis.fetch mock

CI caught what my local run could not. Nineteen live FedEx tests failed on the first
push: `fedEx.track` and its groups ran with `{ concurrency: true }`, so the fetch mock
belonging to `FedEx estimatedDeliveryDate` was installed while those tests were making
real calls, and they got the estimatedDeliveryTimeWindow fixture instead of FedEx.

nock hid this. It intercepted only the specific host and path it was given, and each
interceptor was consumed once, so a mocked test could safely overlap a live one.
`t.mock.method(globalThis, 'fetch', ...)` is process-wide and cannot.

So every subtest in the files that mock fetch is now awaited, and `concurrency: true`
is gone from those groups. Awaiting is the right thing regardless — an un-awaited
node:test subtest can pass without running its assertions — but with a global mock it
is load-bearing rather than merely tidy.

Locally this looked identical before and after, because the tests it broke need
credentials I do not have. That is the whole reason to read the CI run rather than
trust a local pass.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

312 of 373 branches covered (83.65%)

Branch coverage included in aggregate %.

1494 of 1715 relevant lines covered (87.11%)

17.18 hits per line