stores-com / bloodhound / 30505542785

84%

main: 88%

Build Type

Pull #173

github

Committed by freshlogic

Commit Message

refactor!: remove geocoding

Bloodhound geocoded DHL and USPS event locations to resolve the timezone for
timestamps that carry no UTC offset. That is now gone: no Google call, no API key,
no Redis cache, and best effort with the data the carrier actually sends.

Removed util/geography.js and its tests, the `geocoder` and `pettyCache` options,
and the node-geocoder, petty-cache, tz-lookup and us-states-normalize dependencies.
GOOGLE_API_KEY and the Redis service are gone from CI.

Three behavior changes, all visible to consumers:

- DHL and USPS timestamps are interpreted in `defaultTimezone`, falling back to the
  host machine's timezone. A scan in a different zone is off by the difference, which
  can move a date across midnight. README now says to set it explicitly.
- DHL `events[].address.city` comes from the UTAPI's `addressLocality` instead of the
  geocoder, and `.state` is undefined — the UTAPI has no state field, so state was
  only ever available by geocoding. Not guessed from the zip.
- USPS `events[].address.city`/`.state` are returned as USPS supplies them, without
  the geocoder's correction for values like "New York, NY".

Worth flagging for review: no existing test asserted on DHL or USPS
`address.city`/`.state`, so none of this was covered either locally or in CI. Added
an assertion pinning the DHL address shape, and confirmed it fails if `city` stops
reading addressLocality.

`request` now survives only via dhl-ecommerce-solutions@0.4.0, which #169 bumps —
after that it leaves the tree entirely.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #173: refactor!: remove geocoding

Coverage Stats

306 of 366 branches covered (83.61%)

Branch coverage included in aggregate %.

70 of 80 new or added lines in 2 files covered. (87.5%)

2 existing lines in 2 files now uncovered.

1449 of 1714 relevant lines covered (84.54%)

16.85 hits per line