source-academy / plugins / 30499946537

97%

feat/add-init-infra: 67%

push

github

Restore Binary Tree / General Tree view modes to the data visualizer (#81)

* Restore Binary Tree / General Tree view modes

Prof Martin flagged that dropping these during the Conductor port
(deleted outright, "now fully unused") was a mistake — they're an
important feature, not dead weight. Ports the old pre-Conductor
frontend's classification (isBinaryTree/isGeneralTree) and layout
(initializeTreeMetaData) algorithms from dataVisualizer.tsx/Tree.tsx,
and the two drawers, onto the new wire format:

- classify.ts: re-derives cycle/shared-structure detection and
  binary/general-tree classification against SerializedDataVisualizerNode
  (a tagged N-ary "array" node) instead of the old code's raw nested-pair
  walking (`structures[0]`/`structures[1]` on live objects), generalized
  from a fixed 2-element-pair representation since a native list isn't
  fixed at length 2. Keyed by RefId instead of WeakMap<object, _> — no
  live object identity crosses the wire.
- BinaryTreeDrawer.tsx/GeneralTreeDrawer.tsx: the drawing algorithms
  themselves are an unchanged, verified line-for-line port (every
  leftCOUNTER/rightCOUNTER/EY1/EY2/scalerV/originIndex calculation) —
  only the state-access pattern changed, from the old code's global
  DataVisualizer statics (DataVisualizer.isBinTree, .TreeDepth, ...) to
  an injected per-call ClassificationResult.
- BaseTreeNode.ts: restores nodePos/nodeColor, populated in
  Tree.fromSerializedNode from the classification's computed layout.
- Tree.ts: draw() now takes a ViewMode and returns the matching drawer
  instance (mirrors the old Tree.tsx's draw()) instead of drawing
  directly — callers now do `.draw(viewMode).draw(x, y, key)`.
- DataVisualizerView.tsx: a global Original/Binary Tree/General Tree
  toggle, applying across every call and argument (matching the old
  tool's single static toggle). Doesn't hide anything — a structure
  that isn't actually the selected shape still renders, via the
  drawers' own "not a bin... (continued)

305 of 323 branches covered (94.43%)

Branch coverage included in aggregate %.

233 of 235 new or added lines in 6 files covered. (99.15%)

581 of 592 relevant lines covered (98.14%)

26.48 hits per line