source-academy / plugins / 30451757216

97%

feat/add-init-infra: 67%

push

github

fix: reveal the Stepper tab on load instead of stealing focus with showTab (#83)

Mirrors the Data Visualizer host plugin's already-correct reasoning (see its
constructor): a plugin merely becoming available when its conductor loads
shouldn't unconditionally steal focus from whatever the student is looking
at - showTab() is for a plugin deciding, on its own, that the student should
be looking at it right now, which isn't true yet at construction time
(before any steps exist).

This doesn't regress the common "click the Stepper tab" flow: that click
already sets the tab-bar selection directly (see frontend's stepperTab.ts),
before this plugin even finishes loading, so revealTab()'s "become visible
without changing selection" is exactly sufficient once it does.

Companion fix to source-academy/frontend#4195, which addresses the tab
bar's other bug in this same area (the Stepper tab's conductor switch
wiping the Data Visualizer tab via a since-removed unconditional clearTabs()
call) - unrelated to this specific showTab/revealTab choice, but found and
fixed together.

Co-authored-by: Shrey Jain <“shreyjain5132@email.com>

129 of 145 branches covered (88.97%)

Branch coverage included in aggregate %.

322 of 336 relevant lines covered (95.83%)

7.32 hits per line