codenotary / immudb / 30472424263
85%
master: 85%

LAST BUILD BRANCH: dependabot/go_modules/github.com/prometheus/common-0.70.1
DEFAULT BRANCH: master
Ran
Jobs 1
Files 311
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 84.975% (+0.02%) from 84.96%
30472424263

Pull #2115

gh-ci

vchaindz 
ci(coverage): stop swallowing test failures, and drop the unused codecov config

The Coverage job ended its test run with `|| true`, which defeated the
`set -o pipefail` on the line directly above it. A failing or panicking package
was discarded, the partial coverage.txt was uploaded regardless, and the job
reported success. A real test failure therefore surfaced only as a slightly
lower coverage percentage on coveralls — indistinguishable from ordinary
measurement noise, and invisible in the job status.

Capture go-acc's exit status instead. The profile is still uploaded, so a failed
run does not also become a reporting blind spot, and the job then fails with an
explicit ::error:: naming the exit code. In push.yml the check is placed after
`docker rm -f minio` so the container is torn down even when the run failed.

Also removes codecov.yml. No workflow references codecov — coverage goes to
coveralls via goveralls in pull.yml and push.yml — so the file only misled
anyone editing it expecting an effect.

Verified: both workflows still parse as YAML (5 and 10 jobs); the modified run
blocks pass `bash -n`; no `${{ }}` interpolation was introduced; and the
exit-status logic was exercised directly — pass exits 0, failure exits non-zero
while still performing the upload.

Not addressed here, deliberately: coverage is measured nondeterministically
(consecutive master builds drift by ~0.006% with no coverage-relevant change),
and the external coverage/coveralls status reports failure even when coverage
increases. That status is set from the coveralls.io project settings, not from
this repository.
Pull Request #2115: ci(coverage): stop swallowing test failures, and drop the unused codecov config

45228 of 53225 relevant lines covered (84.98%)

124555.17 hits per line

Coverage Regressions

Lines Coverage ∆ File
4
83.65
 -0.15% embedded/store/immustore.go
2
86.18
 1.04% embedded/appendable/multiapp/multi_app.go
Jobs
ID Job ID Ran Files Coverage
1 30472424263.1 311
84.98
Source Files on build 30472424263