hyperledger / fabric-x-committer / 30467002604

91%

Build Type

push

github

Committed by web-flow

Commit Message

[sidecar] Validate and split _snapshot/_checkpoint system transactions (#702)

#### Type of change

- New feature
- Documentation update

#### Description

- On `_snapshot` commit, create a native zero-copy DB clone BEFORE the
marker's
txID commits, then rewrite the marker to a PENDING `SnapshotState`
carrying the
clone name — persisted atomically with the txID by the normal commit
path
  (invariant: txID committed <=> clone exists <=> PENDING row).
- Clone as of current time via plain `CREATE DATABASE ... TEMPLATE` (no
`AS OF`):
  the snapshot TX is drained/standalone, so "now" is the exact cut.
- Both backends: YugabyteDB `TEMPLATE` clone (source stays live;
requires
`enable_db_clone` + a PITR snapshot schedule); PostgreSQL `TEMPLATE ...
  STRATEGY=FILE_COPY` behind the ALLOW_CONNECTIONS/terminate dance.
- Skip cloning when the snapshot txID already exists in `tx_status`
(resubmission
or duplicate) so no orphan clone is left behind; a duplicate clone name
is
  treated as reuse. Clones are never dropped here.
- Wire the clone into the committer before the commit retry loop; on
clone
  failure the batch is not committed and the coordinator re-drives it.
- Reuse `committerpb.IsSystemNamespace`/`SystemNamespaces` from
fabric-x-common
  (bump the dep) and drop the duplicated local helpers.

#### Additional details (Optional)

- `adminExec` runs clone/admin DDL on a dedicated out-of-pool connection
with a
bounded dial timeout and is deliberately not retried (deterministic DDL
errors;
  42P04 "already exists" is mapped to success).
- Test-only `EnsureSnapshotScheduleForCloning` provisions the required
YugabyteDB
snapshot schedule per test DB (yb-admin; no SQL API); the container
enables
  `enable_db_clone`.
- Docs: added a snapshot subsection to `docs/validator-committer.md` and
a
provisioning/tuning step to `docs/deployment-guide.md` noting the
schedule is
  mandatory and retention should be kept short.
- Verified with `make test-all-db` (YugabyteDB snaps... (continued)

Coverage Stats

119 of 131 new or added lines in 2 files covered. (90.84%)

37 existing lines in 12 files now uncovered.

10563 of 11569 relevant lines covered (91.3%)

34970.27 hits per line