agama-project / agama / 30453877312

84%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(web): reworks product not found screen (#3768)

## TL;DR

When the installer cannot get hold of the product to install, the
overview no longer leaves users at a dead end: it explains the
situation, points at the network settings, and offers to look again once
a connection is in place, reporting progress while it does. The software
page gets the same treatment when it cannot read the repositories.
Wording is reused from what is already translated, so nothing waits on
the string freeze.

## Main changes

Gives users a way out when the installer cannot get hold of the product
to install, instead of leaving them on a screen that never recovers.

- The bare "Product not found" empty state on the overview now gets the
same treatment the software page already used for this situation: an
icon, the explanation, the *"This might be due to network
connectivity."* hint, and a **Go to network settings** link.
- That screen also offers a **Reload** action. Pointing at the network
settings was not enough on its own: once a connection is set up, nothing
makes the installer look for the product again, so users were left on
the same dead end they started from. Reloading asks the backend to read
the software information again.
- The software page offers the same two actions when it cannot read the
repositories. It is the same problem seen from the other side, one
showing up on the online medium and the other on the offline one, and
until now that page reported the failure and stopped there.
- The install button is not rendered at all. It used to be shown
disabled, offering an action that can never succeed in this state.
- The page intro goes away too. Both *"Take a moment to review the
installation settings..."* and *"When ready, click on the [install]
button..."* describe a flow that is not available, and the second one
points at a button that is no longer there.
- The system information card stays: it is how users identify the
machine the installer is running... (continued)

Coverage Stats

4924 of 6853 branches covered (71.85%)

Branch coverage included in aggregate %.

69 of 96 new or added lines in 11 files covered. (71.88%)

21 existing lines in 4 files now uncovered.

25695 of 29925 relevant lines covered (85.86%)

123.66 hits per line