source-academy / plugins / 30435878721

97%

feat/add-init-infra: 67%

push

github

Add unit tests for web/data-visualizer's Tree and OriginalDrawer (#80)

* Add unit tests for web/data-visualizer's Tree and OriginalDrawer

common and runner already had solid coverage, but web/data-visualizer
- the package with the actually intricate logic - had none: cycle
handling in Tree.fromSerializedNode, and OriginalDrawer's pixel math
(getNodeWidth/getNodeHeight, backward-arrow routing). That gap is how
the margin-clipping bug shipped silently earlier.

Covers: plain non-shared arrays, a self-referential array (proves
getNodeWidth/getNodeHeight terminate instead of recursing through the
cycle, and that the self-loop correctly routes as a backward arrow),
a shared-but-acyclic structure (proves sharing alone does NOT trip the
backward-arrow path), a malformed unresolved-ref fallback, and basic
width/height growth invariants. Every pixel value is hand-traced
against the real formulas, not just re-derived from them.

* Close remaining coverage gaps: function nodes, formatLeaf, ArrayDrawable

Follow-up to the earlier tree/OriginalDrawer tests, closing gaps that
those tests inadvertently exposed rather than covered (importing
Tree.ts pulls in the whole package - including 5 previously-untracked
drawable components - for the first time, so istanbul started scoring
their unexecuted render() bodies against the aggregate).

Added: a "function" wire-node case (construction, sharing, and drawing
- FunctionTreeNode.createDrawable was completely untested), the real
Tree.draw() entry point DataVisualizerView.tsx actually calls (only
OriginalDrawer directly was tested before), OriginalDrawer's other
top-level branch (a bare leaf with no pair/array), formatLeaf's
truncation/quoting logic, and ArrayDrawable's render() - the one
drawable with real branching (empty-vs-leaf slots, separator line
count, the BoxMinWidth clamp for a real zero-element list case).

Left uncovered on purpose: ArrowDrawable, BackwardArrowDrawable,
FunctionDrawable, NullDrawable - static ... (continued)

129 of 145 branches covered (88.97%)

Branch coverage included in aggregate %.

322 of 336 relevant lines covered (95.83%)

7.32 hits per line