kobotoolbox / kpi / 30434883855

82%

master: 76%

push

github

feat(bulkProcessing): disable bulk approve option if nothing to approve DEV-2495 DEV-2505 (#7322)


### 📣 Summary

Disable "Approve all selected" option if none of selected submissions
has things to approve.

### 💭 Notes

Previously you could pick a bunch of rows whose transcripts (or
translations) were already approved, hit `Approve all selected`, walk
through the confirmation dialog, and get a "No submissions were
approved" warning at the end. Now the menu item stays disabled unless at
least one selected row in that column has automatic content still
awaiting approval.

Changes here:

- `submissionUtils.tsx` — new `hasAnyUnacceptedAutomaticContent()`
helper, a thin wrapper over the existing
`hasUnacceptedAutomaticContent()` used by the per-cell `Review` button.
- `tableColumnSortDropdown.tsx` — new optional `isBulkApproveDisabled`
prop.
- `table.tsx` — pulled the "selected rows on the current page" filter
out of `openBulkProcessingModal()` into a `getSelectedSubmissions()`
method, since the column header now needs it too, and passed the new
prop down.
- `submissionUtils.tests.ts` — unit tests for the helper: empty
selection, all-approved, mixed, translations in the wrong language, and
rows with no supplemental details at all.

### 👀 Preview steps

1. ℹ️ have an account and a project with an audio question and a few
submissions
2. go to Project → Data → Table and transcribe some audio via the column
menu → `Transcribe selected audio files`, wait for it to finish
3. approve those transcripts (per row `Review` button, or select them
and use `Approve all selected`) so the transcript cells show plain text
instead of a `Review` button
4. select only those already-approved rows via the row checkboxes
5. open the transcript column header menu
6. 🔴 [on main] `Approve all selected` is clickable; click through it and
land on a "No submissions were approved. They may already be approved or
have no data." warning
7. 🟢 [on PR] `Approve all selected` is greyed out... (continued)

9551 of 12864 branches covered (74.25%)

30911 of 37708 relevant lines covered (81.97%)

5.51 hits per line