hyperledger / fabric-x-committer / 30427832488

91%

Build Type

push

github

Committed by web-flow

Commit Message

[coordinator] Split the VC request/response API from the VC manager (#713)

#### Type of change

- Improvement (improvement to code, performance, etc)

#### Description

- Move the load-balanced vcservice connection, and the request/response
calls it serves
(`SetLastCommittedBlockNumber`, `GetNextBlockNumberToCommit`,
`GetTransactionsStatus`,
`GetNamespacePolicies`, `GetConfigTransaction`), out of
`validatorCommitterManager` and into a new
`validatorCommitterAPI`. These calls are served by whichever vcservice
the load-balanced
connection picks and are issued outside the transaction pipeline, so the
manager is now
  responsible only for streaming transactions to the vcservices.
- The coordinator owns the API and creates it in `Run` before starting
the managers. The
`channel.Ready` handshake that existed only to tell the coordinator when
the manager had assigned
its `commonClient` is therefore removed, along with the `WaitForReady`
call in `Run`.
- `newVcMgrTestEnv` waits for the vcservice connections instead of that
handshake, matching what
  `newSvMgrTestEnv` already does for the verifiers.

#### Related issues

- resolves partly #611

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Coverage Stats

54 of 67 new or added lines in 2 files covered. (80.6%)

28 existing lines in 7 files now uncovered.

10456 of 11464 relevant lines covered (91.21%)

34931.8 hits per line