hyperledger / fabric-x-committer / 30427229518

91%

Build Type

push

github

Committed by web-flow

Commit Message

[coordinator] Fix VC manager in-flight transaction tracking (#710)

#### Type of change

- Bug fix
- Test update

#### Description

- Return the transactions to `txBeingValidated` when forwarding their
results fails, so that
`recoverPendingTransactions` can re-queue them instead of dropping them.
The signature verifier
  manager already guards this invariant, the VC manager did not.
- Move the map insertion into a new `addTxsBeingValidated`, mirroring
the verifier manager, so the
  key is computed in one place.
- Key `validatorCommitter.txBeingValidated` by `servicepb.Height` rather
than `TxRef.TxId`, again
mirroring the verifier manager. The height is the transaction's own
identity within the block, so
matching a status back to its node no longer depends on transaction IDs
being unique among the
  transactions currently in flight.

#### Additional details (Optional)

The failed-forward re-add is currently reachable only while the manager
itself is tearing down,
because both output writes are bound to the manager's context rather
than the stream's. It is
guarded here so the invariant holds regardless of how those contexts are
wired later.

`TestValidatorCommitterAddAndRecoverPendingTxs` covers the add/recover
round trip that the guard
relies on.

#### Related issues

- resolves #608

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Coverage Stats

7 of 9 new or added lines in 1 file covered. (77.78%)

17 existing lines in 6 files now uncovered.

10455 of 11454 relevant lines covered (91.28%)

34207.65 hits per line