valkyrjaio / sindri-java / 30418777941

100%

push

github

[CI] Align the test tree and bring it under Spotless, ErrorProne, SpotBugs, and ArchUnit (#60)

# Description

Brings sindri-java in line with the test-root rule codified in
valkyrjaio/architecture#79, and closes
the static-analysis gap that left its 58 test files unchecked by every
tool.

**The test tree was half-migrated.** Fixtures already sat at
`io.sindri.tests.fixtures`, but all 57
unit tests were still at `io.sindri.unit.*` — so the repo carried both
layouts at once. They now sit
under `io.sindri.tests.unit.*`, matching PHP `Valkyrja\Tests\`,
TypeScript `tests/Tests/`, and
valkyrjaio/valkyrja-java#63. The compiled fixture, `NullRegexConstant`,
is renamed
`NullRegexConstantFixture` per the reference implementation's rule —
everything under `Fixtures\`
takes the suffix, exempting only enums, traits, and interfaces.

**The AST sample fixtures are renamed too.**
`src/test/resources/Fixtures` holds 60 `.java` files
that are parsed as text rather than compiled, and every one still
carried the pre-migration `*Class`
naming. They are not reachable by ArchUnit — nothing compiles them — so
no rule would ever have
caught them, but they are the same fixtures under the same namespace,
and TypeScript renamed its
equivalent ts-morph samples when it closed this migration. All 60 now
take the `*Fixture` suffix,
along with three type names the samples reference without declaring
(`TestEventClass`, `TestListenerClass`, `TestCliRouteProviderClass`), so
nothing under the fixtures
namespace is named `*Class` any more. The `vendor/` samples are
deliberately untouched: they sit
outside `Fixtures/` and stand in for third-party framework classes.

**No tool saw the tests.** Error Prone, SpotBugs, and ArchUnit all
pointed only at
`src/main/java`, their own test source sets were empty, and Spotless
targeted `src/**/*.java` alone
— sindri never received the equivalent of valkyrjaio/valkyrja-java#58.
Every job's `files:` filter
had the matching hole, so a test-only change s... (continued)

533 of 534 branches covered (99.81%)

Branch coverage included in aggregate %.

1529 of 1529 relevant lines covered (100.0%)

4.38 hits per line