valkyrjaio / sindri-java / 30418286712

100%

push

github

[Http] Read dynamic route annotations and carry their parameter flags (#61)

# Description

Two defects that between them made a dynamic route unusable from the
generated cache.

**1. `@DynamicRoute` was never read.** `HttpRouteAttributeReader`
collected a method's route
annotations with `getNameAsString().equals("Route")`, so every
`@DynamicRoute` was silently
skipped and its route vanished from the generated data — the application
routed it when
collected at runtime and 404'd when running cached. The PHP reader scans
for both
`#[Route]` and `#[DynamicRoute]`; this brings the Java reader in line,
and also reads the
`parameters = {@Parameter(...)}` a dynamic route declares inline.

**2. A parameter's optional and capture flags were dropped.**
`HttpRouteParameterReader`
reads `isOptional` and `shouldCapture` into `HttpParameterData`, but
both the regex
computation and the emitted parameter list rebuilt the framework
`Parameter` from only its
name and regex. A parameter declared `shouldCapture = false` was
generated as a named
capture group, and an optional one lost its optionality — so the cached
regex did not match
what the framework builds at runtime.

Found while adding one route per routing permutation to the example
application
(valkyrjaio/valkyrja-starter-app-java), whose non-capturing permutation
generated
`(?<value>[a-zA-Z]+)` instead of `(?:[a-zA-Z]+)`. Verified end to end:
with this build the
example application generates the non-capturing group and every
permutation's regex matches
the processor's own output.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [x] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`ast/HttpRouteAttributeR... (continued)

533 of 534 branches covered (99.81%)

Branch coverage included in aggregate %.

18 of 18 new or added lines in 2 files covered. (100.0%)

1529 of 1529 relevant lines covered (100.0%)

4.38 hits per line